Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with C++17, remove nonstd::string_view #5151

Merged
merged 3 commits into from
Apr 23, 2021

Conversation

Web-eWorks
Copy link
Member

@Web-eWorks Web-eWorks commented Mar 10, 2021

It's finally time - I got fed up with how difficult it is to implement compile-time hashing in C++11, so I might as well merge this branch in.

I make no guarantees this runs on linux or compiles on MSVC; the branch has been sitting for two months but it worked then. Now I'll go back to rewriting the renderer... mutters into the wind

This should be good to go, though I'd prefer if fluffy, TheEG et. al. can take a look and make sure it builds properly on our different development environments. I haven't updated any documentation, but this will require at least Clang 5 / GCC 7 to build, potentially even higher versions as we add more C++17 libraries.

@Web-eWorks
Copy link
Member Author

Will merge changes from #5156 into this branch so it can be merged sometime over the weekend.

@fluffyfreak
Copy link
Contributor

I was trying to review/test it and applying all those changes thinking: "I'm sure that I've done this before" 🤣

I'll wait until you've merged them over instead of redoing them, ugh I am so tired tonight.

@Web-eWorks
Copy link
Member Author

Changes have been merged, the VS solution needs touchup to compile as c++17, but otherwise good to go.

@fluffyfreak
Copy link
Contributor

@Web-eWorks just pushed the VS2019 fixes directly. So it should be good to go whenever you like 👍

@Web-eWorks
Copy link
Member Author

@Web-eWorks just pushed the VS2019 fixes directly. So it should be good to go whenever you like +1

Excellent! Will merge once CI finishes running.

@impaktor
Copy link
Member

@fluffyfreak we / @pcercuei and @The-EG were talking about updating the cmake and build scripts such that VS files will be nuked for good. My understanding is, after this update, it will be a one-click change needed in VS, then it's good to go. Just wanted to give you a heads up, and an opportunity to throw a fit :)

@Web-eWorks Web-eWorks merged commit 7412aa7 into pioneerspacesim:master Apr 23, 2021
@fluffyfreak
Copy link
Contributor

@fluffyfreak we / @pcercuei and @The-EG were talking about updating the cmake and build scripts such that VS files will be nuked for good. My understanding is, after this update, it will be a one-click change needed in VS, then it's good to go. Just wanted to give you a heads up, and an opportunity to throw a fit :)

@impaktor Sure, propose it via a PR I guess and give me a chance to test it out. I've had issues with the CMake builds before and never understood modifying them.

@Web-eWorks Web-eWorks deleted the cpp17 branch April 29, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants