Fix that sometimes ships get stuck the moment they start to dock

[Gliese852]

• Fix that sometimes ships get stuck the moment they start to dock.
• Fix that during a long free flight the autopilot constantly corrects the course towards the target and this leads to unnecessary fuel consumption. Сan't reproduce
• Add a simple queue for docking with the station in order to somewhat reduce the probability of a collision of ships It didn't work out that easy, let's postpone

Also in order to find out which ships are in a given frame, I implemented the Frame::GetBodiesInside function, and for its work - the CollisionSpace::GetGeoms function.

[Gliese852]

sorry for the force pushes, minor alterations

[Gliese852]

Turned into a draft, because the queue does not work well at large time accelerations

[fluffyfreak]

No single-line if/for statements please, always use brackets especially with something like this.

[Web-eWorks]

We have a decent amount of single-body-line if statements without brackets, though I agree in this case that if the body of the if statement is greater than one line it should have brackets.

[fluffyfreak]

What happens to the queue at large time accelerations?
And if we're under high time acceleration can we skip the proper docking and just swtich from arrings straight to docked?

[Gliese852]

@fluffyfreak

What happens to the queue at large time accelerations?

I noticed that with large accelerations of time, the queue begins to grow, up to dozens of ships, although with normal acceleration, there are a maximum of 2 ships in the queue (we have a very small flow)

And if we're under high time acceleration can we skip the proper docking and just swtich from arrings straight to docked?

yes, we will probably do so, although in the future I would like to see ships in the queue for which there is still no room at the station.

[fluffyfreak]

Hey @Gliese852 what's happening wiht the PR? It seemed really promising.
If the work done so far is good, but you want to do more eventually, hten how about putting it up for review now and do the future work in a new PR?

[Gliese852]

@fluffyfreak the fact is that the third part (with a queue), I would like to remake it strongly enough, I can remove it from the PR for now, and leave it with the first two parts (they are quite working).
We are going to greatly change the docking process (remove the "tossing" of the ship, remove the docking animation, change the tag system so that the autopilot can fly inside the station, make an assist mode so that the player can easily land manually on the rotating station). This is all related to how the work of the queue in the station will look like in the end, so I put it off.

[Bodasey]

@Gliese852 If it's easy to separate the bugfix part from the new feature/improvement part, i please you to do as fluffyfreak proposed. I propose this in general to avoid annoying extra efforts and clarifications when you hard test a "redesigned internal code" branch and you first find a lot of things who are heritage from master branch.

First test: Superior conjunctions of the destination during the flight are done better (the ship now passes in front of the star and not behind any more), but you can still run out of fuel. The autopilot should realize them earlier? Get a better idea of the destination's position at an expected time of arrival?

[Gliese852]

All that was left of my PR was just one line, although it is quite useful.
It may partially alleviate the effect of #5735