Fix SIGSEGV on switch to system map after HJ #5077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web-eWorks
reviewed
Dec 15, 2020
If you turn on the ships in the system map, turn off the system map and jump into another system, then pointers to the ships from the previous system remain in m_projectables, which cause the a segfault. Now clear this when switching from view.
Gliese852
force-pushed
the
sysmap-segv-after-hj-with-ships-on
branch
from
7f8ae93
to
cc5b860
Compare
Web-eWorks
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you turn on the ships in the system map, turn off the system map and jump into another system, then pointers to the ships from the previous system remain in
m_projected, which cause the a segfault. Now clear this when switching from view.