Use new icons in Worldview #5042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Minor tweaks to icons.svg - Change population generation of stations and starports to get usable data - Refactor ui.registerModule to support reloading - Add helper function to vertically center text on long (e.g. icon) lines
|
Great! Only the overview window size scares me a little, it seems to have increased, how will this work at a lower resolutions? |
|
@Gliese852 I tested it at 800x600 and it works just fine; I've made it expand to cover a greater fraction of the screen at smaller resolutions but I consider that to be acceptable behavior as you're going to have it closed most of the time. |
|
@Web-eWorks The set has the Libra of Justice icon as well, if you still want it somewhere |
|
Going to merge this without the Libra set as it's having some rendering issues with the cloned half of the icon. Will integrate that for the next release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final feature PR before feature freeze, I promise! This one fought me trying to get everything properly aligned and working.
Now we use Nozmajner's shiny new icons in the worldview and system view...