Prevent change of Pioneer's mouse pointer when hiding HUD #4827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pi::DrawGUI==false
), prevent a change of Pioneer's custom mouse pointer back to the system default pointer (fixes Mouse cursor changes when you hide HUD #4762)Remarks
As mentioned in #4812 (comment), the fix is to comment out three lines of code which change an imgui mouse setting:
In fact, a few lines below an analogous change was already made in 5824d0a by @Web-eWorks:
Note that I have no real understanding of the imgui API at all. All I did when trying to find a fix for #4812 was to search for places in the code that are triggered when the HUD is off, i.e. places referencing
Pi::DrawGUI
. So I don't know if this is the proper way to do it. As @Web-eWorks commented in the code,So there might be a better way to do it.
Nevertheless, I have checked that both #4762 and #4812 are fixed with this. I also tried to make sure that my uneducated fix does not introduce any new bugs. At least I did not experience any problems while test-playing this.