-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add imgui gauges and planetary information #4067
Conversation
Would the inner text on those progress bars be readable in lower resolutions? |
Just gave it a quick spin. Looks good. Here's what I noticed:
|
2913e85
to
ee61809
Compare
4a34fa4
to
cc7f55c
Compare
I can't reproduce 1., seems to be fixed ;) |
Modules can now add gauges with ui.registerGauge (see data/pigui/modules/gauges.lua for details). Latitude/Longitude are now shown with imgui.
It looks good! Also I'd prefer continuous gauges instead of gaps too. |
Just looking in pigui, your tabs are 2 big? @laarmen what tab width do we use for lua? Personally, I use 2, but for pioneer, I think it's 4 on C++ side? Sorry, don't mean to go into the most boring part of coding... Tested this. I can no longer tell if the temperature/planet info window is on top of the options window, as they no longer overlapp (and it's not movable by default), so I assume it's good. |
Just looking in pigui, your tabs are 2 big?
@laarmen what tab width do we use for lua?
Personally, I use 2, but for pioneer, I think it's 4 on C++ side?
I'd be glad if we could decide on *one* indentation width for lua and
C++, I'd like to put in a cleanup PR that fixes indentation of all files
some time in the future ;) clang-format is a great tool for getting
C++ code in line ;)
|
1 tab = 4 spaces in C++ |
Updated Screenshot:
Video: https://nofile.io/f/RmxMJxqKkWL/gauges.mp4