Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imgui gauges and planetary information #4067

Merged
merged 1 commit into from
Aug 12, 2017

Conversation

ecraven
Copy link
Contributor

@ecraven ecraven commented Aug 5, 2017

Updated Screenshot:
gauges

Video: https://nofile.io/f/RmxMJxqKkWL/gauges.mp4

@ecraven ecraven added the WIP label Aug 5, 2017
@radcapricorn
Copy link
Contributor

Would the inner text on those progress bars be readable in lower resolutions?

@ecraven
Copy link
Contributor Author

ecraven commented Aug 6, 2017

Not ideal, but still readable to me ;) 1024x768
small

@impaktor
Copy link
Member

impaktor commented Aug 9, 2017

Just gave it a quick spin. Looks good. Here's what I noticed:

  1. the temperature window is still visible when in options menu "on top" of it.

  2. I'm not sure, but I suspect the position of the bars move if one of the bars isn't needed and therefore not drawn? I'd expect the xy of each bar relative the screen be fixed regardless if, say preassure, is drawn or not. I might be wrong, but I thought something moved when I went into space.

@ecraven ecraven force-pushed the gauges branch 2 times, most recently from 2913e85 to ee61809 Compare August 11, 2017 07:31
@ecraven ecraven removed the WIP label Aug 11, 2017
@ecraven ecraven changed the title WIP: Add temperature, pressure, hull and shield gauges for player Add imgui gauges and planetary information Aug 11, 2017
@ecraven ecraven force-pushed the gauges branch 4 times, most recently from 4a34fa4 to cc7f55c Compare August 11, 2017 11:42
@ecraven
Copy link
Contributor Author

ecraven commented Aug 11, 2017

I can't reproduce 1., seems to be fixed ;)
As for 2., I'd prefer a neatly stacked list of gauges to one with holes in it (especially if modules start adding their own gauges). Is that incorrect reasoning?

Modules can now add gauges with ui.registerGauge (see
data/pigui/modules/gauges.lua for details).

Latitude/Longitude are now shown with imgui.
@fluffyfreak
Copy link
Contributor

It looks good! Also I'd prefer continuous gauges instead of gaps too.

@impaktor
Copy link
Member

Just looking in pigui, your tabs are 2 big?

@laarmen what tab width do we use for lua?

Personally, I use 2, but for pioneer, I think it's 4 on C++ side?

Sorry, don't mean to go into the most boring part of coding...

Tested this. I can no longer tell if the temperature/planet info window is on top of the options window, as they no longer overlapp (and it's not movable by default), so I assume it's good.

@ecraven
Copy link
Contributor Author

ecraven commented Aug 12, 2017 via email

@fluffyfreak
Copy link
Contributor

1 tab = 4 spaces in C++

@ecraven ecraven merged commit 16424e0 into pioneerspacesim:master Aug 12, 2017
@ecraven ecraven deleted the gauges branch August 12, 2017 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants