Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Info: model not updating when starting new game #4897

Closed
craigo- opened this issue Jun 25, 2020 · 1 comment · Fixed by #4999
Closed

Ship Info: model not updating when starting new game #4897

craigo- opened this issue Jun 25, 2020 · 1 comment · Fixed by #4999

Comments

@craigo-
Copy link
Contributor

craigo- commented Jun 25, 2020

Observed behaviour

When starting a new game that happens to have the same model as the previous game, the Ship Information screen shows the old model, including its colour scheme, registration and any changes to its plane of rotation.

Expected behaviour

A new game shows a new ship in the default plane of rotation.

Steps to reproduce

  1. Start a new game on Mars
  2. Go to the Ship Information screen, drag the model to show its underside (the model's registration is correct)
    image
  3. End Game
  4. Start a new game on Mars
  5. Go to the Ship Information screen (the model's colour scheme, registration and plane of orientation is all preserved from the previous game)
    image

My pioneer version (and OS):

Pioneer:
master 619ed1b x64 (built 20191216)
release 20200203
master 6ff573a x64 (built 20200621)

OS:
Windows 10 Enterprise 1909 x64

NB: this issue does not happen in Pioneer release 20190203.

(See also #4895, possibly related.)

opengl.txt

@Web-eWorks
Copy link
Member

It definitely wouldn't happen in 20190203 because that's before the new model spinner was written. 😄

I'm pretty sure this is just an issue where the model in the spinner isn't being refreshed, which I should be able to adopt @vakhoir's refresh() paradigm to address. I'll look into it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants