Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the time warping functionality #63

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

noahweber1
Copy link
Collaborator

Difference of this notebook to the previous baseline https://github.com/pinellolab/DNA-Diffusion/blob/dna-diffusion/notebooks/experiments/conditional_diffusion/dna_diff_baseline_conditional_UNET.ipynb

is time warping.

Time warping (from https://arxiv.org/pdf/2211.15089.pdf)

The basic idea here is that we can smartly select the noise and use it to learn more efficiently. Selection of the noise happens through selecting optimal time values.

It has been tested and we have similiar computation time while having lower KL values under same seed setting as previously.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ttunja
Copy link
Collaborator

ttunja commented Jan 18, 2023

Fixed Noahs version:

  1. Erased initial time_warping (no use of time_warping as in CDCD paper, since our t space discrete and taking CDF of discrete t-s doesn't make much sense). Instead implemented simple version of "time_warping" where we learn for t-s where loss is big.
  2. Fixed kl_divergence metrics (before was relative entropy, similar)
  3. Added Jensen-Shannon divergence as a symetric metrics.
  4. Trained and seen the convergence of the loss (converges faster than without time_warping with small additional time complexitiy)

@mateibejan1 mateibejan1 merged commit 80b81ad into dna-diffusion Feb 16, 2023
@ttunja ttunja deleted the time_warping branch March 9, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants