Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how we manage time #372

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Improve how we manage time #372

merged 5 commits into from
Nov 30, 2023

Conversation

pil0u
Copy link
Owner

@pil0u pil0u commented Nov 29, 2023 •
edited
Loading

Summary of changes and context

  • Created Aoc.release_time(day) method
  • Renamed lock_time -> lewagon_lock_time
  • Created explicit time zones (the US one and mine) to use when necessary
  • Tidy up a little the Aoc class

Sanity checks

  • Linters pass
  • Tests pass
  • Related GitHub issues are linked in the description

@pil0u pil0u marked this pull request as ready for review November 29, 2023 14:53
@pil0u pil0u requested a review from Aquaj November 29, 2023 14:53
@pil0u pil0u mentioned this pull request Nov 29, 2023
Merged
3 tasks
@pil0u pil0u changed the title Time-related stuff Improve how we manage time Nov 30, 2023
@pil0u pil0u merged commit 8e9c33f into main Nov 30, 2023
5 checks passed
@pil0u pil0u deleted the pilou/readable-intervals-v2 branch November 30, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wJoenn wJoenn wJoenn approved these changes

@Aquaj Aquaj Awaiting requested review from Aquaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pil0u @wJoenn