Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all external link targets from ext to _blank #340

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

Aquaj
Copy link
Collaborator

@Aquaj Aquaj commented Nov 20, 2023

Summary of changes and context

Closes #330.

Sanity checks

  • Linters pass
  • Tests pass
  • Related GitHub issues are linked in the description

@pil0u
Copy link
Owner

pil0u commented Nov 20, 2023

erb-lint qui casse un peu les pieds, faut ajouter une option aux liens...

            <%= f.label :accepted_coc, class: "text-sm" do
                  "I have read and I will comply with the #{link_to(
                    'Code of Conduct',
                    code_of_conduct_path,
                    target: :_blank,
                    rel: :noopener,
                    class: 'link-explicit link-internal'
                  )}".html_safe
                end %>

@Aquaj Aquaj requested a review from pil0u November 20, 2023 22:07
@Aquaj
Copy link
Collaborator Author

Aquaj commented Nov 20, 2023

Erreurs de linter corrigées.

@pil0u pil0u merged commit 58c2167 into main Nov 21, 2023
5 checks passed
@pil0u pil0u deleted the chore/fix-link-targets branch November 21, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changer les targets de nouveaux lien en _blank
2 participants