Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix compareScenConf.R, harmonize some units #640

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Aug 9, 2024

  • fix the initialization of readCheckScenarioConfig: read from remindmodel and only if that somehow does not work, define local version. I think that worked before with the local = TRUE trick, but it does not work anymore.
  • match all names(cfg), not only names(cfg$gms)
  • in case of added column, write NA -> newvalue and do not load the default value here
  • harmonize some units (we use %, not P/percent, and unitless, not -)

@orichters orichters merged commit 940c3a4 into pik-piam:master Aug 9, 2024
2 checks passed
@orichters orichters deleted the units branch August 19, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants