Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Conditional Connector type #31

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Conversation

gabrielguarisa
Copy link
Collaborator

@gabrielguarisa gabrielguarisa commented Sep 3, 2024

Create a new node type called ConditionalConnector (with BureauConnector as alias) that will be used as an Input node, but with dinamically created input connections based on the given schema.

Copy link

github-actions bot commented Sep 3, 2024

coverage

Coverage Report
FileStmtsMissCoverMissing
retrack/engine
   base.py49688%30, 70, 79, 83, 90, 93
   executor.py1082181%52, 60, 72–73, 122, 176, 185–186, 214–218, 228–245, 251
   request_manager.py67790%17, 36, 55, 70–71, 149, 152
   rule.py49394%78, 99, 106
retrack/nodes
   check.py41393%23, 26, 89
   constants.py76396%113, 116, 143
   math.py43198%75
retrack/nodes/dynamic
   base.py16194%26
   csv_table.py43295%59, 62
   flow.py44198%18
retrack/utils
   component_registry.py1052180%25, 77–78, 81–82, 85–86, 91–92, 101, 112–123, 130–131
   exceptions.py281836%14–24, 42–63, 76–97, 106–127
   graph.py56886%35, 46, 59, 61, 63, 74, 79, 81
   registry.py39685%24–27, 48, 53, 61
retrack/validators
   base.py3167%10
   node_exists.py14286%35, 37
TOTAL121610491% 

Tests Skipped Failures Errors Time
66 0 💤 0 ❌ 0 🔥 3.131s ⏱️

Copy link

github-actions bot commented Sep 3, 2024

coverage

Coverage Report
FileStmtsMissCoverMissing
retrack/engine
   base.py49688%30, 70, 79, 83, 90, 93
   executor.py1082181%52, 60, 72–73, 122, 176, 185–186, 214–218, 228–245, 251
   request_manager.py67790%17, 36, 55, 70–71, 149, 152
   rule.py49394%78, 99, 106
retrack/nodes
   check.py41393%23, 26, 89
   constants.py76396%113, 116, 143
   math.py43198%75
retrack/nodes/dynamic
   base.py16194%26
   csv_table.py43295%59, 62
   flow.py44198%18
retrack/utils
   component_registry.py1052180%25, 77–78, 81–82, 85–86, 91–92, 101, 112–123, 130–131
   exceptions.py281836%14–24, 42–63, 76–97, 106–127
   graph.py56886%35, 46, 59, 61, 63, 74, 79, 81
   registry.py39685%24–27, 48, 53, 61
retrack/validators
   base.py3167%10
   node_exists.py14286%35, 37
TOTAL121610491% 

Tests Skipped Failures Errors Time
66 0 💤 0 ❌ 0 🔥 3.278s ⏱️

Copy link

github-actions bot commented Sep 3, 2024

coverage

Coverage Report
FileStmtsMissCoverMissing
retrack/engine
   base.py49688%30, 70, 79, 83, 90, 93
   executor.py1082181%52, 60, 72–73, 122, 176, 185–186, 214–218, 228–245, 251
   request_manager.py67790%17, 36, 55, 70–71, 149, 152
   rule.py49394%78, 99, 106
retrack/nodes
   check.py41393%23, 26, 89
   constants.py76396%113, 116, 143
   math.py43198%75
retrack/nodes/dynamic
   base.py16194%26
   csv_table.py43295%59, 62
   flow.py44198%18
retrack/utils
   component_registry.py1052180%25, 77–78, 81–82, 85–86, 91–92, 101, 112–123, 130–131
   exceptions.py281836%14–24, 42–63, 76–97, 106–127
   graph.py56886%35, 46, 59, 61, 63, 74, 79, 81
   registry.py39685%24–27, 48, 53, 61
retrack/validators
   base.py3167%10
   node_exists.py14286%35, 37
TOTAL121610491% 

Tests Skipped Failures Errors Time
66 0 💤 0 ❌ 0 🔥 3.430s ⏱️

Copy link

github-actions bot commented Sep 3, 2024

coverage

Coverage Report
FileStmtsMissCoverMissing
retrack/engine
   base.py49688%30, 70, 79, 83, 90, 93
   executor.py1082181%52, 60, 72–73, 122, 176, 185–186, 214–218, 228–245, 251
   request_manager.py67790%17, 36, 55, 70–71, 149, 152
   rule.py49394%78, 99, 106
retrack/nodes
   check.py41393%23, 26, 89
   constants.py76396%113, 116, 143
   math.py43198%75
retrack/nodes/dynamic
   base.py16194%26
   csv_table.py43295%59, 62
   flow.py44198%18
retrack/utils
   component_registry.py1052180%25, 77–78, 81–82, 85–86, 91–92, 101, 112–123, 130–131
   exceptions.py281836%14–24, 42–63, 76–97, 106–127
   graph.py56886%35, 46, 59, 61, 63, 74, 79, 81
   registry.py39685%24–27, 48, 53, 61
retrack/validators
   base.py3167%10
   node_exists.py14286%35, 37
TOTAL121610491% 

Tests Skipped Failures Errors Time
66 0 💤 0 ❌ 0 🔥 3.219s ⏱️

@gabrielguarisa gabrielguarisa merged commit 88b73c8 into main Sep 4, 2024
4 checks passed
@gabrielguarisa gabrielguarisa deleted the f/new-connector-node-type branch September 4, 2024 12:33
Copy link
Collaborator

@caiodallaqua caiodallaqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


def conditional_connector_factory(
inputs: typing.Dict[str, typing.Any], **kwargs
) -> typing.Type[BaseDynamicNode]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não conhecia essa anotação. Faz todo sentido pra metaprog!

**conditional_connector_metadata
)

assert issubclass(ConditionalConnector, pydantic.BaseModel)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, issubclass tb não conhecia (ou não lembrava). Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants