MFA using an Authenticator app #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
OK, I think I've addressed all of the review comments now. Thanks for the really helpful input. My plan is to release this tomorrow, so I can get the corresponding Piccolo Admin PR passing, and then release that shortly after. |
Skelmis
reviewed
Sep 8, 2024
|
Just the one final comment otherwise it looks all good to me at face value! Loving the work |
|
OK, ready to merge - thanks again! I think the next improvement I'd love to have is account lockout if a user fails the MFA too many times. But that can be in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you look at
example_projects/mfa_demothere's an example project, where MFA using an authenticator app works.The authenticator MFA backend is pretty much done.
The email MFA is only half done - I might remove it from this PR.
Remaining tasks: