fix _get_type - check for NoneType
#254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## v1 #254 +/- ##
=====================================
Coverage ? 92.34%
=====================================
Files ? 33
Lines ? 2039
Branches ? 0
=====================================
Hits ? 1883
Misses ? 156
Partials ? 0 |
sinisaos
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
@dantownsend I can confirm that these changes are working as they should.
|
@sinisaos Thanks for checking 👍 Just added one more test, but seems to failing. |
|
@dantownsend Just an idea. If I use types.UnionType (because I think that Python 3.10 and above does not understand import types
if origin is t.Union or origin is types.UnionType:
# same as beforethe tests pass. |
|
@sinisaos Ah, great catch! I'll change it. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dantownsend
added a commit
that referenced
this pull request
Oct 20, 2023
* pydantic v2 support (#245) * pydantic_v2_support * pin to Piccolo v1 * add comment * remove KeyError Exception * upgrade coverage * fix type warnings with `nested` * fix mypy warnings * update black * replacement for `outer_type` * change assertion --------- Co-authored-by: Daniel Townsend <dan@dantownsend.co.uk> * update github actions * bumped version * fix `_get_type` - check for `NoneType` (#254) * fix `_get_type` - check for `NoneType` * add tests * fix typo * add a test for the new union syntax * also check for `UnionType` * bumped version * update JSON schema (#257) * bumped version * Update requirements.txt --------- Co-authored-by: sinisaos <sinisaos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #245 (comment)