Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin FastAPI and Pydantic 1 version #238

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

sinisaos
Copy link
Member

@sinisaos sinisaos commented Jul 7, 2023

Related to this issue

@dantownsend
Copy link
Member

I'm going to see if pydantic[email]>=1.6,<2.0 works, just in case they release a critical bug fix version to v1, we had better not pin to a single version.

@codecov-commenter
Copy link

Codecov Report

Merging #238 (e0adeee) into master (16704dd) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          33       33           
  Lines        2021     2021           
=======================================
  Hits         1870     1870           
  Misses        151      151           

@dantownsend dantownsend merged commit 2ae8711 into piccolo-orm:master Jul 7, 2023
13 checks passed
@sinisaos sinisaos deleted the pin_fastapi_version branch July 8, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants