Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure LazyTableReference isn't resolved until referenced table has been initialised #758

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

dantownsend
Copy link
Member

Resolves #757

@dantownsend dantownsend added the bug Something isn't working label Jan 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #758 (30dbaa0) into master (b13c383) will increase coverage by 0.11%.
The diff coverage is 97.18%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
+ Coverage   90.91%   91.03%   +0.11%     
==========================================
  Files         109      109              
  Lines        8214     8257      +43     
==========================================
+ Hits         7468     7517      +49     
+ Misses        746      740       -6     
Files Changed Coverage Δ
piccolo/columns/base.py 95.65% <75.00%> (-0.27%) ⬇️
piccolo/columns/reference.py 93.75% <96.77%> (+3.27%) ⬆️
piccolo/apps/migrations/auto/serialisation.py 95.67% <100.00%> (+0.48%) ⬆️
piccolo/columns/column_types.py 88.45% <100.00%> (+0.12%) ⬆️
piccolo/conf/apps.py 91.86% <100.00%> (+0.07%) ⬆️
piccolo/table.py 96.88% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@dantownsend dantownsend mentioned this pull request Jul 26, 2023
@dantownsend
Copy link
Member Author

I'll keep this open for now, but improvements were made in #1040, so I'm not sure if this PR is required any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LazyTableReference sometimes fails
2 participants