Deprecated the read_exif_data() alias

php · Jul 8, 2017 · ba28d75 · ba28d75
1 parent 5c6e0b1
commit ba28d75
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/NEWS b/NEWS
@@ -12,6 +12,7 @@ PHP                                                                        NEWS
   . Fixed bug #74878 (Data race in ZTS builds). (Nikita)
 
 - EXIF:
+  . Deprecated the read_exif_data() alias. (Kalle)
   . Fixed bug #74428 (exif_read_data(): "Illegal IFD size" warning occurs with 
     correct exif format). (bradpiccho at gmail dot com, Kalle)
   . Fixed bug #72819 (EXIF thumbnails not read anymore). (Kalle)

diff --git a/UPGRADING b/UPGRADING
@@ -164,6 +164,9 @@ PHP 8.0.
   . The create_function() function has been deprecated, use anonymous functions
     instead.
   . The each() function has been deprecated, use a foreach loop instead.
+
+- EXIF:
+  . The read_exif_data() alias have been deprecated, use exif_read_data() instead.
 
 - GD:
   . png2wbmp() and jpeg2wbmp() have been deprecated.

diff --git a/ext/exif/exif.c b/ext/exif/exif.c
@@ -120,7 +120,7 @@ ZEND_END_ARG_INFO()
  */
 const zend_function_entry exif_functions[] = {
 	PHP_FE(exif_read_data, arginfo_exif_read_data)
-	PHP_FALIAS(read_exif_data, exif_read_data, arginfo_exif_read_data)
+	PHP_DEP_FALIAS(read_exif_data, exif_read_data, arginfo_exif_read_data)
 	PHP_FE(exif_tagname, arginfo_exif_tagname)
 	PHP_FE(exif_thumbnail, arginfo_exif_thumbnail)
 	PHP_FE(exif_imagetype, arginfo_exif_imagetype)

diff --git a/ext/exif/tests/exif_read_exif_data_basic.phpt b/ext/exif/tests/exif_read_exif_data_basic.phpt
@@ -19,6 +19,8 @@ print_r(read_exif_data(dirname(__FILE__).'/test2.jpg'));
 ===Done===
 --EXPECTF--
 *** Testing read_exif_data() : basic functionality ***
+
+Deprecated: Function read_exif_data() is deprecated in %sexif_read_exif_data_basic.php on line 9
 Array
 (
     [FileName] => test2.jpg