Update FilesystemIterator::__construct doc for php 8.2 #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Dec 15, 2022
use the full PHP version Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
use colon instead of comma Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
jawira
force-pushed
the
filesystemiterator_skip_dots
branch
from
8232222
to
c2668d1
Compare
claudepache
pushed a commit
to claudepache/php-doc-en
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm updating documentation for FilesystemIterator::__construct.
Before PHP 8.2 the
FilesystemIterator::SKIP_DOTSwas always set and couldn't be removed, this changed in PHP 8.2.If you are using the default value for
flagsparameter then everything work as expected, but if you are using any other value you have to addFilesystemIterator::SKIP_DOTSto maintain old behavior.You can see an example in https://3v4l.org/HrmZ2.
This already provoked a bug (see phingofficial/phing#1685), that's why I also updated documentation in "breaking changes" section.
This change was added in php/php-src@088e547 and as far as I know it's not part of any pull request, I suppose that's the reason it hasn't been documented yet.