Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing direction type RFC_CHANGING #10

Closed
tigerduck42 opened this issue Jan 18, 2022 · 1 comment · Fixed by #21
Closed

Missing direction type RFC_CHANGING #10

tigerduck42 opened this issue Jan 18, 2022 · 1 comment · Fixed by #21
Assignees
@gregor-j
Labels
enhancement New feature or request

Comments

@tigerduck42
Copy link
Contributor

tigerduck42 commented Jan 18, 2022 •
edited by gregor-j
Loading

Found an issue with missing implemention of direction type RFC_CHANGING

saprfc-kralik/src/Traits/ApiTrait.php

Lines 103 to 107 in 46b785b

$mapping = [
'RFC_EXPORT' => IValue::DIRECTION_OUTPUT,
'RFC_IMPORT' => IValue::DIRECTION_INPUT,
'RFC_TABLES' => ITable::DIRECTION_TABLE
];

throws

phpsap\exceptions\SapLogicException: Unknown SAP Netweaver RFC direction 'RFC_CHANGING'!

saprfc-kralik/src/Traits/ApiTrait.php

Line 109 in 46b785b

throw new SapLogicException(sprintf('Unknown SAP Netweaver RFC direction \'%s\'!', $direction));

SAP
@gregor-j gregor-j self-assigned this Jan 19, 2022
@gregor-j gregor-j added the enhancement New feature or request label Jan 19, 2022
@gregor-j
Copy link
Contributor

gregor-j commented Aug 5, 2024

Found RFC_CHANGING in Gregor Kraliks sapnwrfc.c line 921 and 988.

This was referenced Aug 5, 2024
Closed
Closed
gregor-j added a commit that referenced this issue Aug 5, 2024
@gregor-j
added changing elements to input and output #10
2bcc719
@gregor-j gregor-j linked a pull request Aug 5, 2024 that will close this issue
add missing direction type rfc changing #21
Merged
gregor-j added a commit that referenced this issue Aug 5, 2024
@gregor-j
added changing elements to input and output #10
f845af3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregor-j gregor-j

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add missing direction type rfc changing php-sap/saprfc-kralik
2 participants
@tigerduck42 @gregor-j