Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid pulling sebastian/comparator v5 not compatible with phpunit v10 #255

Conversation

DesignPond
Copy link
Contributor

@DesignPond DesignPond commented Dec 9, 2023

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

Avoid pulling sebastian/comparator version 5 which is not compatible with phpunit version 10

Why?

Running the project locally fails to pass the tests as it's pulling phpunit version 10 which is not compatible with sebastian/comparator version 5 for the SebastianBergmann\Comparator\Comparator::assertEquals assertion.

How to reproduce it

composer inst
composer test

PHP Fatal error:  Declaration of SebastianBergmann\Comparator\ArrayComparator::assertEquals(mixed $expected, mixed $actual, float $delta = 0, bool $canonicalize = false, bool $ignoreCase = false, array &$processed = []): void must be compatible with SebastianBergmann\Comparator\Comparator::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false) in /Users/cindyleschaud/Projects/discovery/vendor/sebastian/comparator/src/ArrayComparator.php on line 36

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

To Do

  • If the PR is not complete but you want to discuss the approach, list what remains to be done here

@Nyholm
Copy link
Member

Nyholm commented Dec 9, 2023

Lovely. This is a good temporary solution until PHPUnit Bridge supports PHPUnit 10 properly.

@Nyholm
Copy link
Member

Nyholm commented Dec 9, 2023

Failing test is not related. See #256

@Nyholm Nyholm merged commit 664ded6 into php-http:1.x Dec 9, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants