remove references to generics #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping WG... I'd like to get this merged before more people review the drafts. |
neuro159
approved these changes
Oct 24, 2018
|
@Jean85 bump |
|
Merging anyway because Pullapprove doesn't seem to consider the previous review from @neuro159 |
|
Funny that you remove it, while it is now implemented in PHPStorm: |
|
@thejahweh I'm not saying it can't go back in... it's just that the conversation would need a fresh start. Still, unless multiple other WG projects implement it in a similar way, I worry that a new discussion will derail things like it did before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generics have not been fleshed out, and will potentially not be included in these PSRs. This simply removes lingering references to them from way back when.
This change does not preclude the discussion of inclusion beginning anew on the ML.