Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change socket serializer/version logs to warning. #5534

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Change socket serializer/version logs to warning. #5534

merged 3 commits into from
Aug 2, 2023

Commits on Jul 27, 2023

  1. Change socket serializer/version logs to warning. 

    Often times, random bots or scanners hit URLs with garbage params.
When this happens with a Phoenix socket URL, serializer negotiaiton can
fail and Phoenix will log this event.

Currently this happens at the `:error` level. In most cases, this is
not an error conditions, but an expected failure due to garbage in,
garbage out. As such, it's probably more appropriate for this to be
at the `:warning` level.
    @aselder
    aselder committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d2ce129 View commit details
    Browse the repository at this point in the history

  2. Spell warning correctly.

    @aselder
    aselder committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    4f3dc62 View commit details
    Browse the repository at this point in the history

  3. Randon extra parens.

    @aselder
    aselder committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    0b7aa26 View commit details
    Browse the repository at this point in the history