Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added URLEncodeTask. #973

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Added URLEncodeTask. #973

merged 2 commits into from
Nov 7, 2018

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Oct 20, 2018

Added URLEncodeTask to urlencode() a value to a property:

<urlencode property="a.property" value="äöü" />
<echo msg="${a.property}" />

@siad007 siad007 added this to the 3.0.0-alpha2 milestone Oct 20, 2018
@codecov
Copy link

codecov bot commented Oct 20, 2018

Codecov Report

Merging #973 into master will increase coverage by 0.02%.
The diff coverage is 63.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #973      +/-   ##
============================================
+ Coverage      44.9%   44.92%   +0.02%     
- Complexity     9925     9934       +9     
============================================
  Files           499      500       +1     
  Lines         24053    24072      +19     
============================================
+ Hits          10800    10814      +14     
- Misses        13253    13258       +5
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/property/URLEncodeTask.php 63.15% <63.15%> (ø) 9 <9> (?)
classes/phing/tasks/system/PropertyTask.php 82.5% <0%> (+1.25%) 73% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8b466...a036c66. Read the comment docs.

@mrook mrook merged commit 8fcfe00 into phingofficial:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants