Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added preserve duplicates to PathConvert #969

Merged
merged 4 commits into from
Oct 12, 2018

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Oct 7, 2018

Added preserveduplicates to PathConvert Task.

@siad007 siad007 added this to the 3.0.0-alpha2 milestone Oct 7, 2018
@codecov
Copy link

codecov bot commented Oct 7, 2018

Codecov Report

Merging #969 into master will increase coverage by 0.02%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #969      +/-   ##
===========================================
+ Coverage     44.87%   44.9%   +0.02%     
- Complexity     9921    9924       +3     
===========================================
  Files           499     499              
  Lines         24049   24053       +4     
===========================================
+ Hits          10791   10800       +9     
+ Misses        13258   13253       -5
Impacted Files Coverage Δ Complexity Δ
classes/phing/types/Path.php 58.04% <100%> (+4.02%) 68 <19> (+1) ⬆️
classes/phing/tasks/system/PathConvert.php 61.34% <60%> (-0.4%) 48 <2> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdca258...f86d77f. Read the comment docs.

@mrook mrook merged commit 317ac90 into phingofficial:master Oct 12, 2018
@siad007 siad007 deleted the PreserveDuplicates branch October 12, 2018 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants