Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added silent flag to symfony console task #961

Merged
merged 3 commits into from
Nov 8, 2018

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Sep 29, 2018

Related to #960

Added silent argument to the SymfonyConsoleTask

Copy link
Member

@kenguest kenguest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - just needs to be brought in line with base branch again.

@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@71274ab). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #961   +/-   ##
=========================================
  Coverage          ?   44.93%           
  Complexity        ?     9939           
=========================================
  Files             ?      500           
  Lines             ?    24082           
  Branches          ?        0           
=========================================
  Hits              ?    10822           
  Misses            ?    13260           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
...ng/tasks/ext/SymfonyConsole/SymfonyConsoleTask.php 56.86% <66.66%> (ø) 24 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71274ab...08f37b2. Read the comment docs.

@mrook mrook merged commit 01b789e into phingofficial:master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants