Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersionTask can manage 'v' prefix #955

Merged

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Aug 26, 2018

I modified VersionTask to be able to manage 'v' prefix in version numbers. I also updated the doc and added tests for \VersionTask::getVersion.

I deleted \VersionTask::checkStartingVersion since the regex I added implicitly checks the validity of version too.

@codecov
Copy link

codecov bot commented Aug 26, 2018

Codecov Report

Merging #955 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #955      +/-   ##
===========================================
+ Coverage      44.9%   44.9%   +<.01%     
+ Complexity     9920    9917       -3     
===========================================
  Files           499     499              
  Lines         24044   24034      -10     
===========================================
- Hits          10796   10792       -4     
+ Misses        13248   13242       -6
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/ext/VersionTask.php 78.31% <100%> (-1.26%) 27 <0> (-3)
classes/phing/util/SourceFileScanner.php 71.01% <0%> (+7.24%) 21% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fb5ed...6522474. Read the comment docs.

@siad007 siad007 added this to the 3.0.0-alpha2 milestone Aug 26, 2018
Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ;)

@siad007 siad007 merged commit e64f593 into phingofficial:master Aug 26, 2018
@siad007
Copy link
Member

siad007 commented Aug 26, 2018

Thanks @jawira

@jawira jawira deleted the feature/v-prefix-for-version-task branch October 14, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants