Small additions to the os condition

[siad007]

No description provided.

[codecov]

Codecov Report

Merging #922 into master will not change coverage.
The diff coverage is 81.81%.

@@            Coverage Diff            @@
##             master     #922   +/-   ##
=========================================
  Coverage     44.86%   44.86%           
  Complexity     9875     9875           
=========================================
  Files           499      499           
  Lines         23934    23934           
=========================================
  Hits          10737    10737           
  Misses        13197    13197

Impacted Files	Coverage Δ	Complexity Δ
...asses/phing/tasks/system/condition/OsCondition.php	85.71% <81.81%> (ø)	13 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 752b178...4ccae73. Read the comment docs.

[kenguest]

Is netware still "a thing"? I'm not sure about the need to add support for operating systems that have been discontinued.

[siad007]

But this is a addition to the OsCondition so why should this condition not be able to determine a netware system?

[kenguest]

A quick search for "PHP on NetWare" shows that "PHP for NetWare® is based on open source PHP version 4.2.3 and PHP version 5.0.5.".

Unless that is grossly inaccurate and PHP 7.1 can run on that discontinued operating system, I think you are adding code that will never execute.

(https://github.com/phingofficial/phing/blob/master/composer.json currently specifies a minimum version of PHP 7.1 for phing, but you know that anyway)

[mrook]

I have the same comments about "dos". So, let's stick to detecting linux/mac/windows?

[siad007]

Hmm there seems to be a problem with a test from #907 on https://travis-ci.org/phingofficial/phing/jobs/387075667 - strange that this test was not failing before?! Any hints?

[mrook]

@siad007 it did actually fail before, but the failure was ignored for a while because of the codecov upload. See 8aea675#diff-b4553af39acae935d505c76e139d4aa3.

[siad007]

@mrook it becomes stranger after executing the failing test on my environment (windows) with no failure.

[mrook]

@siad007 yeah I've noticed the test runs fine when run on its own, but fails when the entire test suite is run. Side-effect of another test? Cleanup gone wrong?