Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent usage of to string #913

Merged
merged 2 commits into from
May 11, 2018

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Apr 21, 2018

  • Consistent usage of __toString
  • Selector usage is now logged in debug mode:
  +Task: pathconvert
Property ${line.separator} => 

    -calling setter PathConvert::setPathSep()
    -calling setter PathConvert::setProperty()
    -calling setter PathConvert::setRefid()
FileSet: Setup file scanner in dir . with patternSet{ includes: abc/**  excludes: empty }
{orselect: {filenameselector name: **\exportspecial\** negate: false casesensitive: true}, {notselect: {noneselect: {filenameselector name: **\*export*\** negate: false casesensitive: true}}}}

@siad007 siad007 added the core label Apr 21, 2018
@siad007 siad007 added this to the 3.0.0-alpha2 milestone Apr 21, 2018
@codecov
Copy link

codecov bot commented Apr 21, 2018

Codecov Report

Merging #913 into master will increase coverage by 0.15%.
The diff coverage is 35.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #913      +/-   ##
============================================
+ Coverage     44.12%   44.27%   +0.15%     
- Complexity     9696     9699       +3     
============================================
  Files           493      493              
  Lines         23628    23630       +2     
============================================
+ Hits          10425    10463      +38     
+ Misses        13203    13167      -36
Impacted Files Coverage Δ Complexity Δ
classes/phing/Target.php 92.63% <ø> (-0.16%) 48 <0> (-1)
classes/phing/system/io/PhingFile.php 67.34% <ø> (-0.27%) 115 <0> (-1)
classes/phing/types/DataType.php 95.34% <ø> (+20.93%) 19 <0> (ø) ⬇️
classes/phing/types/selectors/SizeSelector.php 0% <0%> (ø) 43 <3> (ø) ⬇️
classes/phing/types/selectors/ContainsSelector.php 0% <0%> (ø) 27 <3> (ø) ⬇️
classes/phing/types/selectors/DepthSelector.php 0% <0%> (ø) 22 <1> (ø) ⬇️
classes/phing/tasks/ext/property/PathToFileSet.php 0% <0%> (ø) 18 <0> (ø) ⬇️
classes/phing/types/selectors/NotSelector.php 0% <0%> (ø) 4 <2> (ø) ⬇️
classes/phing/types/selectors/OrSelector.php 0% <0%> (ø) 5 <2> (ø) ⬇️
classes/phing/types/selectors/NoneSelector.php 0% <0%> (ø) 5 <2> (ø) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc68fc...2f12265. Read the comment docs.

@mrook mrook merged commit 4d1b68a into phingofficial:master May 11, 2018
@siad007 siad007 deleted the ConsistentUsageOfToString branch May 13, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants