Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP CodeSniffer cache write to directory #890

Merged
merged 2 commits into from
Apr 14, 2018

Conversation

ruifil
Copy link
Contributor

@ruifil ruifil commented Mar 26, 2018

Fix error of PHP_CodeSniffer_Reports_PhingRemoveFromCache try to write to content to directory path :
[PHP Error] file_put_contents(/data/): failed to open stream: Is a directory [line 191 of /data/library/vendor/squizlabs/php_codesniffer/CodeSniffer/Reporting.php]

Fix error of PHP_CodeSniffer_Reports_PhingRemoveFromCache try to write to content to directory path :
[PHP Error] file_put_contents(/data/): failed to open stream: Is a directory [line 191 of /data/library/vendor/squizlabs/php_codesniffer/CodeSniffer/Reporting.php]
Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@siad007 siad007 added this to the 3.0.0-alpha2 milestone Apr 14, 2018
@siad007 siad007 added the defect label Apr 14, 2018
@siad007 siad007 merged commit 244ed46 into phingofficial:master Apr 14, 2018
@siad007
Copy link
Member

siad007 commented Apr 14, 2018

@ruifil Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants