Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixed whitespace issue on argument escaping. #735

Merged
merged 21 commits into from
Jul 2, 2018

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Jun 24, 2017

Related to #637

@siad007 siad007 added this to the 3.0 milestone Jun 24, 2017
@siad007 siad007 changed the title Fixed whitespace issue on argument escaping. [WIP] Fixed whitespace issue on argument escaping. Jun 24, 2017
@mrook mrook modified the milestones: 3.0, 3.0 RC2 Dec 18, 2017
@mrook
Copy link
Member

mrook commented Feb 13, 2018

@siad007 can you take a look at the failing test(s)?

@siad007 siad007 mentioned this pull request Mar 11, 2018
@mrook
Copy link
Member

mrook commented Jun 25, 2018

@siad007 now that #878 has been merged - do you want to clean up the rest or should we close this?

@siad007
Copy link
Member Author

siad007 commented Jun 30, 2018

@mrook i will cleanup here asap :)

siad007 and others added 4 commits June 30, 2018 16:59
# Conflicts:
#	classes/phing/tasks/system/ExecTask.php
#	classes/phing/types/Environment.php
#	classes/phing/types/environment/EnvVariable.php
#	test/etc/tasks/system/ExecTest.xml
@codecov
Copy link

codecov bot commented Jul 2, 2018

Codecov Report

Merging #735 into master will decrease coverage by <.01%.
The diff coverage is 73.8%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #735      +/-   ##
===========================================
- Coverage     44.91%   44.9%   -0.01%     
- Complexity     9877    9920      +43     
===========================================
  Files           499     499              
  Lines         23938   24040     +102     
===========================================
+ Hits          10751   10796      +45     
- Misses        13187   13244      +57
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/system/AttribTask.php 0% <0%> (ø) 21 <1> (ø) ⬇️
classes/phing/tasks/system/ApplyTask.php 72.5% <68.78%> (-22.53%) 102 <72> (+33)
classes/phing/types/Commandline.php 69.4% <70.83%> (+2.98%) 65 <40> (+6) ⬆️
...asses/phing/tasks/system/condition/OsCondition.php 84.61% <85.71%> (-1.1%) 17 <0> (+4)
classes/phing/tasks/system/ExecTask.php 87.81% <96.15%> (-0.08%) 84 <39> (ø)
classes/phing/Task.php 88.23% <0%> (+3.92%) 22% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75d5e1f...4237206. Read the comment docs.

@siad007 siad007 merged commit 3d1c41e into phingofficial:master Jul 2, 2018
@siad007 siad007 deleted the FixedExecTask branch July 2, 2018 21:56
@siad007 siad007 mentioned this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants