Make imported targets available as importname.targetname #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies to access imported files' path and directory. See ticket phingofficial#620 (http://www.phing.info/trac/ticket/620); this cherry-picks dd97b79 off unstable-3.0.
|
@mrook I cannot really see what your commits linked at http://www.phing.info/trac/ticket/620 do. Are they the same as this PR plus refactorings? Shall I close this? |
|
ping @mrook |
|
I think this PR can be closed, I think I have restored/rewritten all of the changes in this PR. |
|
Yes, #359 shows that the relevant changes seem to be covered. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add properties to access imported files' path and directory.
See ticket #620 (http://www.phing.info/trac/ticket/620); this cherry-picks dd97b79 off unstable-3.0.