Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbdeploy task. fix 960 defect (add missing check all attribute documentation) and fix appliedBy attribute #177

Merged
merged 2 commits into from
Jan 2, 2013

Conversation

remibantos
Copy link

  • Fix SymfonyConsole - ProgressBar output incorrect #960 defect
  • Also fix typo in appliedBy attribute description in AppendixC-OptionalTasks ("deltaset" was duplicated in the attribute name for "appliedBy")
  • Fix and complete phing-grammar for "appliedBy" and "checkall" attributes.

- Also fix typo in appliedBy attribute description in AppendixC-OptionalTasks ("deltaset" was duplicated in the attribute name for "appliedBy")
- Fix and complete phing-grammar for "appliedBy" and "checkall" attributes.
@mrook
Copy link
Member

mrook commented Dec 31, 2012

Thanks for the pull Remi! There are a lot of whitespace changes in the pull though, any chance you could clean that up a little?

@remibantos
Copy link
Author

Oops, i use JetBrains PHPStorm, it has changed several whitespaces with the default XML formatting policy.
Thanks for your feedback, i will change that soon.

…so fix optionaltasks, xml which was not well formed
@remibantos
Copy link
Author

Hi Michiel,

I've restored trailing spaces which were automatically removed by my IDE. It's easier for the diff now.
I've also figured out that optionaltasks.xml file was not well formed. (error in end tags).
I've not taken a look yet to what is done in Travis build yet, but shouldn't this wellFormness problem have been identified by continuous build?

Thanks.

By the way, me and my coworkers are currently using and establishing PHING for legacy PHP apps. And it's very usefull. Even more as we are experienced with ANT :)

@mrook
Copy link
Member

mrook commented Jan 2, 2013

Thanks Remi! The docbook sources aren't yet automatically converted to any other formats, so that's probably why the missing end tags slipped through the cracks.

And thank you for the kind words!

mrook added a commit that referenced this pull request Jan 2, 2013
Fixes #960 - add missing check all attribute documentation, fix appliedBy attribute
@mrook mrook merged commit d229106 into phingofficial:master Jan 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

SymfonyConsole - ProgressBar output incorrect
2 participants