Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VisualizerTask tests #1676

Merged
merged 44 commits into from
Jun 23, 2022
Merged

Conversation

jawira
Copy link
Contributor

@jawira jawira commented May 27, 2022

Update tests for VisualizerTask:

  • File extension must be the same as declared in format property.
<visualizer forma="svg" destination="build"/>      <!-- build.svg -->
<visualizer forma="svg" destination="build.svg"/>  <!-- build.svg -->
<visualizer forma="svg" destination="build.png"/>  <!-- build.png.svg -->

jawira and others added 30 commits February 11, 2019 14:27
@jawira jawira marked this pull request as draft May 27, 2022 22:48
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1676 (2f66659) into main (453bfa2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1676   +/-   ##
=========================================
  Coverage     58.34%   58.34%           
  Complexity     6962     6962           
=========================================
  Files           355      355           
  Lines         16611    16611           
=========================================
  Hits           9692     9692           
  Misses         6919     6919           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453bfa2...2f66659. Read the comment docs.

@jawira jawira marked this pull request as ready for review May 27, 2022 23:05
@mrook mrook merged commit db6d594 into phingofficial:main Jun 23, 2022
@jawira jawira deleted the add-visualizer-tests branch July 9, 2022 07:37
@mrook mrook added this to the 3.0.0-RC4 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants