Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdosqlexec] Fixed PHP 8 compat, Code Cleanup and tests #1628

Merged
merged 14 commits into from
Aug 22, 2021

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Aug 21, 2021

  • Added test and some return types.
  • Added errorproperty
  • Added statementcountproperty
  • Updated grammar

Related to #1626

@siad007 siad007 added this to the 3.0.0-RC3 milestone Aug 21, 2021
@siad007 siad007 self-assigned this Aug 21, 2021
@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #1628 (8948b27) into main (bb891e1) will increase coverage by 0.80%.
The diff coverage is 68.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1628      +/-   ##
============================================
+ Coverage     56.87%   57.68%   +0.80%     
- Complexity     6927     6932       +5     
============================================
  Files           355      355              
  Lines         16778    16790      +12     
============================================
+ Hits           9543     9685     +142     
+ Misses         7235     7105     -130     
Impacted Files Coverage Δ
src/Phing/Task/System/Pdo/PDOQuerySplitter.php 100.00% <ø> (ø)
.../Phing/Task/System/Pdo/PlainPDOResultFormatter.php 19.35% <0.00%> (+19.35%) ⬆️
src/Phing/Task/System/Pdo/PDOSQLExecTask.php 75.40% <64.58%> (+22.26%) ⬆️
...ing/Task/System/Pdo/PDOSQLExecFormatterElement.php 67.14% <70.58%> (+67.14%) ⬆️
src/Phing/Io/BufferedReader.php 81.63% <100.00%> (ø)
.../Phing/Task/System/Pdo/DefaultPDOQuerySplitter.php 97.82% <100.00%> (ø)
...rc/Phing/Task/System/Pdo/DummyPDOQuerySplitter.php 93.33% <100.00%> (+93.33%) ⬆️
...rc/Phing/Task/System/Pdo/PgsqlPDOQuerySplitter.php 86.55% <100.00%> (ø)
src/Phing/Task/System/Pdo/PDOTask.php 72.09% <0.00%> (+9.30%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb891e1...8948b27. Read the comment docs.

@siad007 siad007 changed the title [pdosqlexec] Code Cleanup and tests [pdosqlexec] Fixed PHP 8 compat, Code Cleanup and tests Aug 22, 2021
@siad007 siad007 merged commit 7e6e753 into phingofficial:main Aug 22, 2021
@siad007 siad007 deleted the pdotransactions branch August 22, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

PHP 8 "There is no active transaction" with a pdosqlexec with transaction
1 participant