Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting standard, outfile and format to phpcs task #1612

Merged
merged 4 commits into from
Jun 16, 2021

Conversation

kenguest
Copy link
Member

This brings the phpcs task in line with most of the attributes used/specified in the phpcodesniffer task, making it easier to switch to the newer task.

@kenguest kenguest requested a review from siad007 June 15, 2021 21:50
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #1612 (e033875) into main (f4a49bf) will increase coverage by 0.05%.
The diff coverage is 73.33%.

❗ Current head e033875 differs from pull request most recent head 67292b3. Consider uploading reports for the commit 67292b3 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1612      +/-   ##
============================================
+ Coverage     56.79%   56.84%   +0.05%     
- Complexity     6908     6914       +6     
============================================
  Files           354      354              
  Lines         16733    16748      +15     
============================================
+ Hits           9503     9520      +17     
+ Misses         7230     7228       -2     
Impacted Files Coverage Δ
src/Phing/Task/Optional/PhpCSTask.php 88.33% <73.33%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a49bf...67292b3. Read the comment docs.

@kenguest
Copy link
Member Author

Documentation updated in phingofficial/guide#35

Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siad007 siad007 added this to the 3.0.0-RC2 milestone Jun 16, 2021
@siad007 siad007 merged commit 9bd4e47 into phingofficial:main Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants