Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for StringHelper #1603

Merged
merged 30 commits into from
May 18, 2021
Merged

Conversation

jawira
Copy link
Contributor

@jawira jawira commented May 16, 2021

I wrote more tests for \Phing\Util\StringHelper

@codecov
Copy link

codecov bot commented May 16, 2021

Codecov Report

Merging #1603 (d1e176e) into main (16ae1f0) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1603      +/-   ##
============================================
+ Coverage     56.76%   56.79%   +0.02%     
  Complexity     6908     6908              
============================================
  Files           354      354              
  Lines         16733    16733              
============================================
+ Hits           9499     9503       +4     
+ Misses         7234     7230       -4     
Impacted Files Coverage Δ Complexity Δ
src/Phing/Util/StringHelper.php 100.00% <0.00%> (+11.76%) 21.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ae1f0...d1e176e. Read the comment docs.

@mrook mrook merged commit 173977c into phingofficial:main May 18, 2021
@jawira jawira deleted the stringhelper-tests branch November 23, 2021 22:40
@mrook mrook added this to the 3.0.0-RC4 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants