Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Cleanup some tests. #1587

Merged
merged 10 commits into from
Apr 24, 2021
Merged

[core] Cleanup some tests. #1587

merged 10 commits into from
Apr 24, 2021

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Apr 24, 2021

Added return type hints and removed/changed the requirements annotations.

@siad007 siad007 added core cleanup code cleanup labels Apr 24, 2021
@siad007 siad007 added this to the 3.0.0-RC2 milestone Apr 24, 2021
@siad007 siad007 self-assigned this Apr 24, 2021
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #1587 (e665d17) into main (1152fcf) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1587      +/-   ##
============================================
+ Coverage     56.21%   56.38%   +0.16%     
  Complexity     6915     6915              
============================================
  Files           354      354              
  Lines         16744    16744              
============================================
+ Hits           9413     9441      +28     
+ Misses         7331     7303      -28     
Impacted Files Coverage Δ Complexity Δ
src/Phing/Task/System/Pdo/PDOSQLExecTask.php 53.14% <0.00%> (+8.57%) 75.00% <0.00%> (ø%)
src/Phing/Task/System/Pdo/PDOTask.php 62.79% <0.00%> (+30.23%) 18.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1152fcf...e665d17. Read the comment docs.

@siad007 siad007 merged commit a2dce01 into phingofficial:main Apr 24, 2021
@siad007 siad007 deleted the CleanupTests branch April 24, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup core
Development

Successfully merging this pull request may close these issues.

1 participant