Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrutinizer issue fixes #1580

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Apr 6, 2021

No description provided.

@siad007 siad007 added core scrutinizer fixed scrutinizer issue labels Apr 6, 2021
@siad007 siad007 added this to the 3.0.0-RC2 milestone Apr 6, 2021
@siad007 siad007 self-assigned this Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #1580 (ee5bedc) into main (1377a93) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1580   +/-   ##
=========================================
  Coverage     56.19%   56.19%           
+ Complexity     6916     6915    -1     
=========================================
  Files           354      354           
  Lines         16746    16744    -2     
=========================================
- Hits           9410     9409    -1     
+ Misses         7336     7335    -1     
Impacted Files Coverage Δ Complexity Δ
src/Phing/PropertyHelper.php 82.63% <ø> (ø) 67.00 <0.00> (ø)
src/Phing/ComponentHelper.php 83.03% <100.00%> (+0.39%) 56.00 <48.00> (-1.00) ⬆️
src/Phing/Project.php 79.81% <100.00%> (ø) 132.00 <5.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1377a93...ee5bedc. Read the comment docs.

@siad007 siad007 merged commit 0c3f112 into phingofficial:main Apr 6, 2021
@siad007 siad007 deleted the scrutinizer-fixes-5 branch April 6, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core scrutinizer fixed scrutinizer issue
Development

Successfully merging this pull request may close these issues.

1 participant