Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XmlLintTask] Added error logs. #1575

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Apr 5, 2021

  • Added improved error logging
  • Moved task to system tasks
  • Added test
  • Added build file linter

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #1575 (2783423) into main (ecd056d) will increase coverage by 0.21%.
The diff coverage is 72.09%.

❗ Current head 2783423 differs from pull request most recent head 4a74bfd. Consider uploading reports for the commit 4a74bfd to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1575      +/-   ##
============================================
+ Coverage     55.95%   56.16%   +0.21%     
- Complexity     6909     6917       +8     
============================================
  Files           354      354              
  Lines         16723    16752      +29     
============================================
+ Hits           9357     9409      +52     
+ Misses         7366     7343      -23     
Impacted Files Coverage Δ Complexity Δ
src/Phing/Task/System/XmlLintTask.php 64.19% <72.09%> (ø) 31.00 <23.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd056d...4a74bfd. Read the comment docs.

@siad007 siad007 merged commit cb6a7c3 into phingofficial:main Apr 5, 2021
@siad007 siad007 deleted the XmlLint branch April 5, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant