Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment in test to prevent php8.1 compat issue #1562

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Mar 31, 2021

Without a comment pdepend will raise an error.

preg_match_all(): Passing null to parameter #2 ($subject) of type string is deprecated

Without a comment pdepend will raise an error.
```
preg_match_all(): Passing null to parameter #2 ($subject) of type string is deprecated
```
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #1562 (18e9f46) into main (8212a11) will not change coverage.
The diff coverage is n/a.

❗ Current head 18e9f46 differs from pull request most recent head 436ce79. Consider uploading reports for the commit 436ce79 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1562   +/-   ##
=========================================
  Coverage     55.96%   55.96%           
  Complexity     6913     6913           
=========================================
  Files           355      355           
  Lines         16739    16739           
=========================================
  Hits           9368     9368           
  Misses         7371     7371           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8212a11...436ce79. Read the comment docs.

@siad007 siad007 merged commit 929c03c into main Mar 31, 2021
@siad007 siad007 deleted the siad007-patch-1 branch March 31, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant