Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[condition] Added phpversion condition #1560

Closed
wants to merge 1 commit into from

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Mar 29, 2021

Added phpversion condition:

<condition property="isTrue">
    <phpversion atleast="7.3"/>
</condition>

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #1560 (4738b7a) into main (be91386) will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1560      +/-   ##
============================================
+ Coverage     55.96%   55.99%   +0.02%     
- Complexity     6913     6931      +18     
============================================
  Files           355      356       +1     
  Lines         16739    16769      +30     
============================================
+ Hits           9368     9389      +21     
- Misses         7371     7380       +9     
Impacted Files Coverage Δ Complexity Δ
src/Phing/Task/System/Condition/PhpVersion.php 62.96% <62.96%> (ø) 17.00 <17.00> (?)
src/Phing/Task/System/Condition/ConditionBase.php 81.31% <100.00%> (+0.63%) 32.00 <1.00> (+1.00)
src/Phing/Task/System/Condition/AndCondition.php 100.00% <0.00%> (+20.00%) 3.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be91386...4738b7a. Read the comment docs.

@siad007
Copy link
Member Author

siad007 commented Mar 29, 2021

Closed in favour of existing versioncompare condition.

reminder to myself - add a cookbook with this as an example 😄

@siad007 siad007 closed this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant