Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core]Moved Timer function to DefaultClock #1558

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Mar 21, 2021

No description provided.

@siad007 siad007 added this to the 3.0.0-RC2 milestone Mar 21, 2021
@siad007 siad007 self-assigned this Mar 21, 2021
@siad007 siad007 changed the title Moved Timer function to DefaultClock [core]Moved Timer function to DefaultClock Mar 21, 2021
@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #1558 (d31e644) into main (0ca30dc) will not change coverage.
The diff coverage is 92.85%.

❗ Current head d31e644 differs from pull request most recent head 3046ebf. Consider uploading reports for the commit 3046ebf to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1558   +/-   ##
=========================================
  Coverage     55.96%   55.96%           
  Complexity     6913     6913           
=========================================
  Files           356      355    -1     
  Lines         16739    16739           
=========================================
  Hits           9368     9368           
  Misses         7371     7371           
Impacted Files Coverage Δ Complexity Δ
src/Phing/Phing.php 32.16% <50.00%> (ø) 215.00 <2.00> (ø)
src/Phing/Util/DefaultClock.php 100.00% <100.00%> (ø) 5.00 <4.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ca30dc...3046ebf. Read the comment docs.

@siad007 siad007 merged commit 79da7a3 into phingofficial:main Mar 21, 2021
@siad007 siad007 deleted the RemovedTimer branch March 21, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant