Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add days and hours to DefaultLogger::formatTime method #1554

Merged
merged 4 commits into from
Mar 21, 2021

Conversation

jawira
Copy link
Contributor

@jawira jawira commented Mar 20, 2021

So, I couldn't resist and I added "hours" and "days" too.

Closes #1553.

@siad007 siad007 added this to the 3.0.0-RC2 milestone Mar 20, 2021
@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #1554 (eae013b) into main (14c4a26) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1554      +/-   ##
============================================
+ Coverage     55.75%   55.83%   +0.07%     
- Complexity     6907     6908       +1     
============================================
  Files           356      356              
  Lines         16703    16721      +18     
============================================
+ Hits           9313     9336      +23     
+ Misses         7390     7385       -5     
Impacted Files Coverage Δ Complexity Δ
src/Phing/Listener/DefaultLogger.php 83.16% <100.00%> (+9.67%) 40.00 <6.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c4a26...eae013b. Read the comment docs.

@siad007 siad007 merged commit 135030c into phingofficial:main Mar 21, 2021
@siad007
Copy link
Member

siad007 commented Mar 21, 2021

@jawira thx 😉

@jawira jawira deleted the add-days-and-hours branch March 21, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add hours to output
2 participants