Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fixed deprecation warnings - PHP ^8.1 #1535

Merged
merged 5 commits into from
Feb 14, 2021
Merged

[core] Fixed deprecation warnings - PHP ^8.1 #1535

merged 5 commits into from
Feb 14, 2021

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Feb 13, 2021

  • strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
  • preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated

Related to https://github.com/phingofficial/phing/pull/1534/checks?check_run_id=1894970221

@siad007 siad007 added this to the 3.0.0-rc1 milestone Feb 13, 2021
@siad007 siad007 self-assigned this Feb 13, 2021
@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #1535 (3d273da) into main (3465599) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1535   +/-   ##
=========================================
  Coverage     55.59%   55.59%           
- Complexity     6908     6909    +1     
=========================================
  Files           356      356           
  Lines         16720    16720           
=========================================
  Hits           9295     9295           
  Misses         7425     7425           
Impacted Files Coverage Δ Complexity Δ
src/Phing/Util/PregEngine.php 95.55% <ø> (ø) 19.00 <0.00> (ø)
src/Phing/PropertyHelper.php 82.73% <100.00%> (ø) 67.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3465599...3d273da. Read the comment docs.

`preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated`
@siad007 siad007 changed the title [PropertyHelper] Fixed deprecation warning [core] Fixed deprecation warnings - PHP ^8.1 Feb 13, 2021
@siad007 siad007 removed the defect label Feb 14, 2021
@siad007 siad007 merged commit 3ca6e5e into main Feb 14, 2021
@siad007 siad007 deleted the siad007-patch-1 branch February 14, 2021 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant