Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TryCatchTask] Rectify the logic of the "finally" clause #1534

Merged
merged 3 commits into from
Feb 13, 2021

Conversation

malhusseiny
Copy link
Contributor

In a try-catch statement, the "finally" clause must always run before any uncaught exceptions are thrown up the chain of the calling routine.

@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #1534 (2974300) into main (e71547c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1534      +/-   ##
============================================
+ Coverage     55.54%   55.61%   +0.06%     
  Complexity     6909     6909              
============================================
  Files           356      356              
  Lines         16731    16732       +1     
============================================
+ Hits           9293     9305      +12     
+ Misses         7438     7427      -11     
Impacted Files Coverage Δ Complexity Δ
src/Phing/Task/System/TryCatchTask.php 96.42% <100.00%> (+18.65%) 13.00 <0.00> (ø)
src/Phing/Task/System/ThrowTask.php 66.66% <0.00%> (+66.66%) 6.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71547c...2974300. Read the comment docs.

@siad007 siad007 added this to the 3.0.0-rc1 milestone Feb 13, 2021
@siad007 siad007 changed the title fix: Rectify the logic of the "finally" clause in the TryCatchTask [TryCatchTask] Rectify the logic of the "finally" clause Feb 13, 2021
@siad007 siad007 merged commit a3e2688 into phingofficial:main Feb 13, 2021
@malhusseiny malhusseiny deleted the FixTryCatchTask branch February 14, 2021 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants