Fix PhpEvalTask bugs with functions taking scalar and multidimensional array params #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1531 +/- ##
============================================
+ Coverage 55.27% 55.54% +0.26%
+ Complexity 6918 6913 -5
============================================
Files 356 356
Lines 16742 16731 -11
============================================
+ Hits 9254 9293 +39
+ Misses 7488 7438 -50
Continue to review full report at Codecov.
|
…sional array params
malhusseiny
force-pushed
the
PhpEvalTask
branch
from
1bfcd12
to
6249164
Compare
…sional array params
# Conflicts: # tests/Phing/Task/System/PhpEvalTaskTest.php
mrook
changed the title
|
Thanks @malhusseiny ! |
|
@mrook Anytime :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.