Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pdo tasks and path-as-package task to system scope #1521

Merged
merged 5 commits into from
Jan 31, 2021

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Jan 31, 2021

No description provided.

@siad007 siad007 added this to the 3.0.0-rc1 milestone Jan 31, 2021
@siad007 siad007 self-assigned this Jan 31, 2021
@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #1521 (bb87413) into main (7c2680d) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1521      +/-   ##
============================================
+ Coverage     54.29%   54.31%   +0.01%     
  Complexity     8080     8080              
============================================
  Files           412      412              
  Lines         19564    19570       +6     
============================================
+ Hits          10623    10629       +6     
  Misses         8941     8941              
Impacted Files Coverage Δ Complexity Δ
src/Phing/Task/System/Condition/ConditionBase.php 80.68% <ø> (ø) 31.00 <0.00> (ø)
src/Phing/Task/System/PackageAsPathTask.php 0.00% <ø> (ø) 3.00 <0.00> (?)
...rc/Phing/Task/System/Pdo/DummyPDOQuerySplitter.php 0.00% <ø> (ø) 7.00 <0.00> (?)
src/Phing/Task/System/Pdo/PDOQuerySplitter.php 100.00% <ø> (ø) 1.00 <0.00> (?)
src/Phing/Task/System/Pdo/PDOResultFormatter.php 0.00% <ø> (ø) 3.00 <0.00> (?)
...ing/Task/System/Pdo/PDOSQLExecFormatterElement.php 0.00% <0.00%> (ø) 28.00 <0.00> (?)
src/Phing/Task/System/Pdo/PDOSQLExecTask.php 44.57% <0.00%> (ø) 75.00 <0.00> (?)
...rc/Phing/Task/System/Pdo/PDOSQLExecTransaction.php 88.23% <ø> (ø) 6.00 <0.00> (?)
src/Phing/Task/System/Pdo/PDOTask.php 32.55% <ø> (ø) 18.00 <0.00> (?)
.../Phing/Task/System/Pdo/PlainPDOResultFormatter.php 0.00% <ø> (ø) 12.00 <0.00> (?)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2680d...992e56c. Read the comment docs.

@siad007 siad007 merged commit ddd1a45 into phingofficial:main Jan 31, 2021
@siad007 siad007 deleted the MovePDOTasksSystem branch January 31, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant