[SassTask] [core] - Fixed Filesystem::listContents for numeric filenames. #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lOnErrorIsSeAt test
… or subdirectories
… or subdirectories
Codecov Report
@@ Coverage Diff @@
## master #1511 +/- ##
=========================================
Coverage 53.09% 53.09%
Complexity 8582 8582
=========================================
Files 447 447
Lines 20792 20792
=========================================
Hits 11040 11040
Misses 9752 9752
Continue to review full report at Codecov.
|
siad007
requested changes
Jan 26, 2021
There was a problem hiding this comment.
Thanks for your contribution @malhusseiny - small change requests from my side :)
siad007
changed the title
siad007
approved these changes
Jan 26, 2021
|
@malhusseiny LGTM - thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue that affects all filesystem manipulation tasks dealing with files and directories with all-numeric names and often causes build failures and/or infinite directory traversal loops. Added a simple test for the fix.
Fixed the FailOnError test bug.