Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PatternSet] Simplified __toString method. #1481

Merged
merged 1 commit into from
Dec 20, 2020
Merged

[PatternSet] Simplified __toString method. #1481

merged 1 commit into from
Dec 20, 2020

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Dec 20, 2020

No description provided.

@siad007 siad007 added core cleanup code cleanup labels Dec 20, 2020
@siad007 siad007 added this to the 3.0.0-rc1 milestone Dec 20, 2020
@siad007 siad007 self-assigned this Dec 20, 2020
@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #1481 (b61decb) into master (67acf77) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1481      +/-   ##
============================================
- Coverage     52.93%   52.90%   -0.03%     
+ Complexity     9222     9220       -2     
============================================
  Files           470      470              
  Lines         22385    22376       -9     
============================================
- Hits          11850    11839      -11     
- Misses        10535    10537       +2     
Impacted Files Coverage Δ Complexity Δ
classes/phing/types/PatternSet.php 54.47% <100.00%> (-2.87%) 65.00 <3.00> (-2.00)
classes/phing/tasks/ext/UnzipTask.php 77.27% <0.00%> (-4.55%) 5.00% <0.00%> (ø%)
classes/phing/tasks/ext/HttpTask.php 88.88% <0.00%> (-2.23%) 19.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67acf77...b61decb. Read the comment docs.

@siad007 siad007 merged commit ea34a70 into master Dec 20, 2020
@siad007 siad007 deleted the siad007-patch-4 branch December 20, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup core
Development

Successfully merging this pull request may close these issues.

1 participant