Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new optional clover-html formatter. #1436

Merged
merged 8 commits into from
Nov 25, 2020

Conversation

BlairCooper
Copy link
Contributor

@BlairCooper BlairCooper commented Nov 15, 2020

Fixes #1430

Add runner for PHPUnit 9
Add support for Clover HTML report.
Pass PHPUnit configuration values to filter and code coverage classes.

Fixes #1430

Add runner for PHPUnit 9
Add support for Clover HTML report.
Pass PHPUnit configuration values to filter and code coverage classes.
@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #1436 (4acb8a8) into master (f5ddaa1) will decrease coverage by 0.35%.
The diff coverage is 39.02%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1436      +/-   ##
============================================
- Coverage     54.20%   53.85%   -0.36%     
- Complexity     9137     9202      +65     
============================================
  Files           467      469       +2     
  Lines         22188    22337     +149     
============================================
+ Hits          12028    12030       +2     
- Misses        10160    10307     +147     
Impacted Files Coverage Δ Complexity Δ
...t/formatter9/CloverHtmlPHPUnitResultFormatter9.php 0.00% <0.00%> (ø) 4.00 <4.00> (?)
classes/phing/tasks/ext/phpunit/PHPUnitTask.php 34.81% <20.58%> (-3.36%) 112.00 <0.00> (+13.00) ⬇️
...ses/phing/tasks/ext/phpunit/PHPUnitTestRunner9.php 48.24% <48.24%> (ø) 53.00 <53.00> (?)
...asses/phing/tasks/ext/phpunit/FormatterElement.php 46.66% <50.00%> (+0.32%) 20.00 <0.00> (+1.00)
...ses/phing/tasks/ext/phpunit/PHPUnitTestRunner8.php 0.00% <0.00%> (-46.73%) 54.00% <0.00%> (-6.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ddaa1...4acb8a8. Read the comment docs.

Copy link
Member

@siad007 siad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes from the runner or do it complete - again there are missing stuff!
FYI I have fixed the coverage issue in #1437

@siad007 siad007 marked this pull request as draft November 15, 2020 10:49
@siad007 siad007 marked this pull request as ready for review November 15, 2020 10:49
@siad007 siad007 changed the title Make use of PHPUnit 9 code coverage and reporting Add new optional clover-html formatter. Nov 15, 2020
@siad007 siad007 added this to the 3.0.0-rc1 milestone Nov 15, 2020
BlairCooper and others added 5 commits November 15, 2020 07:41
Fixes #1430

Add runner for PHPUnit 9
Add support for Clover HTML report.
Pass PHPUnit configuration values to filter and code coverage classes.
Put back in the CoverageMerger code but made it conditional on the
coverage-setup task being used so that it is possible to just utilize
the Clover coverage reporting.
@siad007 siad007 merged commit 58b6925 into phingofficial:master Nov 25, 2020
@BlairCooper BlairCooper deleted the clover-html-formatter branch November 26, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Make better use of PHPUnit 9 code coverage and reporting
2 participants